Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xcode): Only parse Plist when required during RN source maps upload #1940

Merged
merged 7 commits into from
Feb 28, 2024
Merged

fix(xcode): Only parse Plist when required during RN source maps upload #1940

merged 7 commits into from
Feb 28, 2024

Conversation

krystofwoldrich
Copy link
Member

If users use debug IDs and auto-release reading is disabled, we don't have to read and part Info.plist.

The same applies when users use ENV to set release and dist

szokeasaurusrex
szokeasaurusrex requested changes Feb 12, 2024
View reviewed changes
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for switching to a match statement; the logic is much clearer to me know, and I was able to identify a way we can simplify the match statement even further. Once you address the suggestion, I am ready to approve.

src/commands/react_native/xcode.rs Outdated Show resolved Hide resolved
szokeasaurusrex
szokeasaurusrex approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@szokeasaurusrex szokeasaurusrex merged commit 5657d86 into master Feb 28, 2024
12 checks passed
@szokeasaurusrex szokeasaurusrex deleted the @krystofwoldrich/fix-read-plist-when-required branch February 28, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

@loewenheim loewenheim Awaiting requested review from loewenheim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @szokeasaurusrex